Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normal Types Page #173

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

codex128
Copy link

@codex128 codex128 commented Nov 8, 2023

This PR creates a page explaining the usage of the NormalType parameter in Lighting.j3md and PBRLighting.j3md according to Issue 2143 in the main JME repo.

@riccardobl
Copy link
Member

Looks good, thanks.
Do we need to add this to a menu or something?

@codex128
Copy link
Author

I think so, but I don't know how to.

@richardTingle
Copy link
Member

richardTingle commented Nov 24, 2023

@codex128 See the file docs/modules/core/nav.adoc. You can see the nav being built there (other files build other parts of the nav but I think thats the one you want). You can see that the parentage is defined by the depth of the *s and there is a simple file path and name specified for the nav item.

I think your xref would be xref:material/normal-types.adoc

So e.g.

** xref:material/normal-types.adoc[Your title goes here]

But you'd need to decide exactly where it goes

@codex128
Copy link
Author

Ah, thanks! I will look into that when I get the chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants